Adding NullStatsReporter and TestScope#69
Open
ravirajj wants to merge 2 commits intouber-java:masterfrom
Open
Conversation
inetchitailo
reviewed
May 4, 2020
There was a problem hiding this comment.
I think you just need to add a single if statement:
if (!(reporter instanceof NullStatsReporter) {
scheduler.scheduleWithFixedDelay(scope.new ReportLoop(uncaughtExceptionHandler), 0, interval.toMillis(), TimeUnit.MILLISECONDS);
}
inetchitailo
reviewed
May 4, 2020
guscastro
reviewed
Jan 18, 2023
| * TestScope is a metrics collector that has no reporting, ensuring that | ||
| * all emitted values have a given prefix or set of tags. | ||
| */ | ||
| interface TestScope extends Scope { |
Contributor
There was a problem hiding this comment.
This interface needs to be public, so that the Snapshot can be consumed externally.
Contributor
|
How would |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NullStatsReporterto report no metrics when it is used byScopeBuilder.TestScopeto snapshot metrics for tests.